Skip to content

cifs: truncate the inode and mapping when we simulate fcollapse

Ronnie Sahlberg requested to merge lsahlber/centos-stream-9:1997367 into main

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1997367 commit 84330d41efb12bc227899e54dbdbe7d9590cb2b7

When we collapse a range in smb3_collapse_range() we must make sure we update the inode size and pagecache accordingly.

If not, both inode size and pagecahce may be stale until it is refreshed.

This can be demonstrated for the inode size by running :

xfs_io -i -f -c "truncate 320k" -c "fcollapse 64k 128k" -c "fiemap -v"
/mnt/testfile

where we can see the result of stale data in the fiemap output. The third line of the output is wrong, all this data should be truncated.

EXT: FILE-OFFSET BLOCK-RANGE TOTAL FLAGS 0: [0..127]: hole 128 1: [128..383]: 128..383 256 0x1 2: [384..639]: hole 256

And the correct output, when the inode size has been updated correctly should look like this:

EXT: FILE-OFFSET BLOCK-RANGE TOTAL FLAGS 0: [0..127]: hole 128 1: [128..383]: 128..383 256 0x1

Reported-by: Xiaoli Feng <xifeng@redhat.com>
Reported-by: kernel test robot <lkp@intel.com>
Cc:  stable@vger.kernel.org
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
(cherry picked from commit 84330d41efb12bc227899e54dbdbe7d9590cb2b7)

Signed-off-by: Ronnie Sahlberg lsahlber@redhat.com

Merge request reports