Skip to content

NFS: Don't loop forever in nfs_do_recoalesce()

Steve Dickson requested to merge steved92/centos-stream-9:bz2069274 into main

Bugzilla: http://bugzilla.redhat.com/2069274

commit d02d81efc7564b4d5446a02e0214a164cf00b1f3 Author: Trond Myklebust trond.myklebust@hammerspace.com Date: Fri Mar 25 21:51:03 2022 -0400

NFS: Don't loop forever in nfs_do_recoalesce()

If __nfs_pageio_add_request() fails to add the request, it will return
with either desc->pg_error < 0, or mirror->pg_recoalesce will be set, so
we are guaranteed either to exit the function altogether, or to loop.

However if there is nothing left in mirror->pg_list to coalesce, we must
exit, so make sure that we clear mirror->pg_recoalesce every time we
loop.

Reported-by: Olga Kornievskaia <aglo@umich.edu>
Fixes: 70536bf4eb07 ("NFS: Clean up reset of the mirror accounting variables")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

Signed-off-by: Steve Dickson steved@redhat.com

Merge request reports