Skip to content

cifs: modefromsids must add an ACE for authenticated users

Ronnie Sahlberg requested to merge lsahlber/centos-stream-9:1988278 into main

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1988278 commit 0c6f4ebf8835d01866eb686d47578cde80097981

When we create a file with modefromsids we set an ACL that has one ACE for the magic modefromsid as well as a second ACE that grants full access to all authenticated users.

When later we chante the mode on the file we strip away this, and other, ACE for authenticated users in set_chmod_dacl() and then just add back/update the modefromsid ACE. Thus leaving the file with a single ACE that is for the mode and no ACE to grant any user any rights to access the file. Fix this by always adding back also the modefromsid ACE so that we do not drop the rights to access the file.

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
(cherry picked from commit 0c6f4ebf8835d01866eb686d47578cde80097981)

Signed-off-by: Ronnie Sahlberg lsahlber@redhat.com

Merge request reports