Skip to content

hwmon: (w83793) Fix NULL pointer dereference by removing unnecessary structure field

Steve Best requested to merge sfbest/centos-stream-9:37725 into main

JIRA: https://issues.redhat.com/browse/RHEL-37725
CVE: CVE-2021-47384

Build Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=61490740
Tested: Did sanity boot testing on Intel (intel-arrowlake-s-02) system.

commit dd4d747ef05addab887dc8ff0d6ab9860bbcd783
Author: Nadezda Lutovinova lutovinova@ispras.ru
Date: Tue Sep 21 18:51:53 2021 +0300

hwmon: (w83793) Fix NULL pointer dereference by removing unnecessary structure field  

If driver read tmp value sufficient for  
(tmp & 0x08) && (!(tmp & 0x80)) && ((tmp & 0x7) == ((tmp >> 4) & 0x7))  
from device then Null pointer dereference occurs.  
(It is possible if tmp = 0b0xyz1xyz, where same literals mean same numbers)  
Also lm75[] does not serve a purpose anymore after switching to  
devm_i2c_new_dummy_device() in w83791d_detect_subclients().  

The patch fixes possible NULL pointer dereference by removing lm75[].  

Found by Linux Driver Verification project (linuxtesting.org).  

Cc: stable@vger.kernel.org  
Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>  
Link: https://lore.kernel.org/r/20210921155153.28098-3-lutovinova@ispras.ru  
[groeck: Dropped unnecessary continuation lines, fixed multi-line alignments]  
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Signed-off-by: Steve Best sbest@redhat.com

Merge request reports