Skip to content

pwm: Fix double shift bug

Steve Best requested to merge sfbest/centos-stream-9:38280 into main

JIRA: https://issues.redhat.com/browse/RHEL-38280
CVE: CVE-2023-52756

Build Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=61487062
Tested: Did sanity boot testing Intel (intel-arrowlake-s-02) system.

commit d27abbfd4888d79dd24baf50e774631046ac4732
Author: Dan Carpenter dan.carpenter@linaro.org
Date: Wed Oct 25 14:58:18 2023 +0300

pwm: Fix double shift bug  

These enums are passed to set/test_bit().  The set/test_bit() functions  
take a bit number instead of a shifted value.  Passing a shifted value  
is a double shift bug like doing BIT(BIT(1)).  The double shift bug  
doesn't cause a problem here because we are only checking 0 and 1 but  
if the value was 5 or above then it can lead to a buffer overflow.  

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>  
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>  
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>  
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

Signed-off-by: Steve Best sbest@redhat.com

Merge request reports