Skip to content

platform/x86/intel/ifs: Call release_firmware() when handling errors.

Steve Best requested to merge sfbest/centos-stream-9:j23312 into main

JIRA: https://issues.redhat.com/browse/RHEL-23312

Build Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=58502477

Tested: Successful run of ifs platform test on Intel system(intel-eaglestream-spr-12).

commit 8c898ec07a2fc1d4694e81097a48e94a3816308d Author: Jithu Joseph jithu.joseph@intel.com Date: Thu Jan 25 00:22:50 2024 -0800

platform/x86/intel/ifs: Call release_firmware() when handling errors.

Missing release_firmware() due to error handling blocked any future image
loading.

Fix the return code and release_fiwmare() to release the bad image.

Fixes: 25a76dbb36dd ("platform/x86/intel/ifs: Validate image size")
Reported-by: Pengfei Xu <pengfei.xu@intel.com>
Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Tested-by: Pengfei Xu <pengfei.xu@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240125082254.424859-2-ashok.raj@intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Signed-off-by: Steve Best sbest@redhat.com

Merge request reports