Skip to content

netfilter: nf_tables: skip set commit for deleted/destroyed sets

Phil Sutter requested to merge psutter1/centos-stream-9:c9s/RHEL-20217 into main

JIRA: https://issues.redhat.com/browse/RHEL-20217 Upstream Status: commit 7315dc1e122c85ffdfc8defffbb8f8b616c2eb1a CVE: CVE-2024-0193

commit 7315dc1e122c85ffdfc8defffbb8f8b616c2eb1a Author: Pablo Neira Ayuso pablo@netfilter.org Date: Tue Dec 19 19:44:49 2023 +0100

netfilter: nf_tables: skip set commit for deleted/destroyed sets

NFT_MSG_DELSET deactivates all elements in the set, skip
set->ops->commit() to avoid the unnecessary clone (for the pipapo case)
as well as the sync GC cycle, which could deactivate again expired
elements in such set.

Fixes: 5f68718b34a5 ("netfilter: nf_tables: GC transaction API to avoid race with control plane")
Reported-by: Kevin Rich <kevinrich1337@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Signed-off-by: Phil Sutter psutter@redhat.com

Edited by Phil Sutter

Merge request reports