Skip to content

Cleanup PCI AER refactoring

Myron Stowe requested to merge mstowe1/centos-stream-9:redhat/core_error_reporting into main 
This series follows through with the cleanup of redundant code now that PCI
Advanced Error Reporting (AER) enablement has been moved into the kernel's
PCI core.

During upstream v6.0, commit f26e58bf6f54 "PCI/AER: Enable error reporting
when AER is native" - which came from upstream merge commit 5a20930f27c4
"Merge branch 'pci/err'" - PCI Advanced Error Reporting (AER) was
refactored.  The refactoring consisted of moving the enablement of error
reporting into the PCI core as opposed to being the responsibility of each
individual device driver.  With this commit the PCI core now sets the Device
Control bits that enable error reporting for PCIe devices.

Upstream commit f26e58bf6f54 was back-ported into RHEL in an earlier release
via commit e416587df70c.

With enablement now taking place within the PCI core, the next step was to
remove all the now redundant enablement and disablement calls from each of
the individual device drivers.  This took place from v6.3 through v6.5 and
is the bulk of this series content: removing all occurrances of
'pci_enable_pcie_error_reporting()' and 'pci_disable_pcie_error_reporting()'
calls from device drivers.

Finally, with AER enablement and disablement removed from all device
drivers, that code could now be completely isolated (i.e., static) to the
PCI subsystem's AER related file.  This took place during v6.6 via the
following commits:
  3e2a87a0cffe  Merge branch 'pci/aer'
  7ec4b34be423  PCI/AER: Unexport pci_enable_pcie_error_reporting()
  69b264df8a41  PCI/AER: Drop unused pci_disable_pcie_error_reporting()

All patches in the series back-ported cleanly.


JIRA: https://issues.redhat.com/browse/RHEL-16039
Depends: N/A

Signed-off-by: Myron Stowe <mstowe@redhat.com>

Merge request reports