Skip to content

block: bio-integrity: Copy flags when bio_integrity_payload is cloned

Ming Lei requested to merge minlei/centos-stream-9:my_9.2-fix-bio-integrity-flags into main

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2164903

commit b6a4bdcda430e3ca43bbb9cb1d4d4d34ebe15c40
Author: Martin K. Petersen martin.petersen@oracle.com
Date: Wed Feb 15 12:18:01 2023 -0500

block: bio-integrity: Copy flags when bio_integrity_payload is cloned  

Make sure to copy the flags when a bio_integrity_payload is cloned.  
Otherwise per-I/O properties such as IP checksum flag will not be  
passed down to the HBA driver. Since the integrity buffer is owned by  
the original bio, the BIP_BLOCK_INTEGRITY flag needs to be masked off  
to avoid a double free in the completion path.  

Fixes: aae7df50190a ("block: Integrity checksum flag")  
Fixes: b1f01388574c ("block: Relocate bio integrity flags")  
Reported-by: Saurav Kashyap <skashyap@marvell.com>  
Tested-by: Saurav Kashyap <skashyap@marvell.com>  
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>  
Reviewed-by: Christoph Hellwig <hch@lst.de>  
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>  
Link: https://lore.kernel.org/r/20230215171801.21062-1-martin.petersen@oracle.com  
Signed-off-by: Jens Axboe <axboe@kernel.dk>

Signed-off-by: Ming Lei ming.lei@redhat.com

Merge request reports