Skip to content

redhat/Makefile: Remove hardcoded BUILD_TARGET entries

Prarit Bhargava requested to merge prarit/centos-stream-9:BUILD_TARGET_fixup into main

Bugzilla: INTERNAL
Upstream Status: RHEL-only.

The dist[g]-brew targets have a hardcoded BUILD_TARGET. This code should
be dropped in favor of using the defaults which will then allow users to
override the BUILD_TARGET variable from Makefile.variables.

Remove the hardcoded BUILD_TARGET entries from the dist[g]-brew targets.

As a result of this change,

'make dist-brew' results in

brew build --scratch rhel-9.2.0-test-pesign /home/prarit/git-kernel/gitlab/centos-stream-9/redhat/rpm/SRPMS/kernel-5.14.0-176.test.el9.src.rpm

'make BUILD_TARGET=mcrib dist-brew' results in

brew build --scratch mcrib /home/prarit/git-kernel/gitlab/centos-stream-9/redhat/rpm/SRPMS/kernel-5.14.0-176.test.el9.src.rpm

and setting BUILD_TARGET in Makefile.variables to 'happyfeet', and executing
'make dist-brew' results in

brew build --scratch happyfeet /home/prarit/git-kernel/gitlab/centos-stream-9/redhat/rpm/SRPMS/kernel-5.14.0-176.test.el9.src.rpm

Note: We have a ticket open (RHELBLD-11164) to generalize the
rhel-(RHEL_MAJOR).(RHEL_MINOR).0-test-pesign brew target to
rhel-$(RHEL_MAJOR)-test-pesign. This would allow that target to be used
in ARK. After that it completed, an ARK MR will be opened.

Signed-off-by: Prarit Bhargava prarit@redhat.com

Merge request reports