Skip to content

sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax

Vratislav Bendel requested to merge vbendel1/centos-stream-9:bz2121392 into main

Merge Request Required Information

Summary of Changes

Bugzilla: https://bugzilla.redhat.com/2121392

Upstream Status: backport from upstream

Tested: simple cmdline test

commit 1622ed7d0743201293094162c26019d2573ecacb
Author: Baokun Li <libaokun1@huawei.com>
Date:   Fri Jan 21 22:13:48 2022 -0800

    sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax

    When we pass a negative value to the proc_doulongvec_minmax() function,
    the function returns 0, but the corresponding interface value does not
    change.

    we can easily reproduce this problem with the following commands:

        cd /proc/sys/fs/epoll
        echo -1 > max_user_watches; echo $?; cat max_user_watches

    This function requires a non-negative number to be passed in, so when a
    negative number is passed in, -EINVAL is returned.

    Link: https://lkml.kernel.org/r/20211220092627.3744624-1-libaokun1@huawei.com


Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Reported-by: Jozef Bacik jobacik@redhat.com

Signed-off-by: Vratislav Bendel vbendel@redhat.com

Approved Bugzilla Ticket

Bugzilla: https://bugzilla.redhat.com/2121392

Merge request reports