Skip to content

netdevsim: don't overwrite read only ethtool parms

Antoine Tenart requested to merge atenart/centos-stream-9:c9s/bz2101836/netdevsim-91-p2 into main

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2101836
Upstream Status: linux.git

commit ee60e626d536da4c710b3634afe68fe7c6d69b59
Author: Filip Pokryvka fpokryvk@redhat.com
Date: Fri Dec 10 18:50:32 2021 +0100

netdevsim: don't overwrite read only ethtool parms  

Ethtool ring feature has _max_pending attributes read-only.  
Set only read-write attributes in nsim_set_ringparam.  

This patch is useful, if netdevsim device is set-up using NetworkManager,  
because NetworkManager sends 0 as MAX values, as it is pointless to  
retrieve them in extra call, because they should be read-only. Then,  
the device is left in incosistent state (value > MAX).  

Fixes: a7fc6db099b5 ("netdevsim: support ethtool ring and coalesce settings")  
Signed-off-by: Filip Pokryvka <fpokryvk@redhat.com>  
Link: https://lore.kernel.org/r/20211210175032.411872-1-fpokryvk@redhat.com  
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: Antoine Tenart atenart@redhat.com

Edited by Antoine Tenart

Merge request reports