Draft: Add stop_housekeeping_cpuslocked()
Merge Request Required Information
Summary of Changes
CPU hotplug interferes with CPU isolation and introduces latency to real-time tasks.
The test:
rtla timerlat hist -c 1 -a 500 &
echo 0 > /sys/devices/system/cpu/cpu2/online
The RTLA tool reveals the following blocking thread stack trace:
-> multi_cpu_stop
-> cpu_stopper_thread
-> smpboot_thread_fn
This happens because multi_cpu_stop() disables interrupts for EACH online CPU since takedown_cpu() indirectly invokes take_cpu_down() through stop_machine_cpuslocked(). I'm omitting the detailed description of the call chain.
Proposal: Limit the stop operation to housekeeping CPUs.
Approved Development Ticket(s)
All submissions to CentOS Stream must reference a ticket in Red Hat Jira.
Click for formatting instructions
Please follow the CentOS Stream contribution documentation for how to file this ticket and have it approved.List tickets each on their own line of this description using the format "Resolves: RHEL-1234", "Related: RHEL-2345" or "Reverts: RHEL-3456", as appropriate.
Merge request reports
Activity
JIRA Hook Readiness Report
Target Branch: main
This merge request fails jirahook validation: JIRAMissing
JIRA Issue tags:
JIRA Issue CVEs Commits Readiness Policy Check Notes UNTAGGED (UNKNOWN) None 199a3bca MISSING Check not done: No JIRA Issue See 1 - No
JIRA
tag was found in these commits. This project requires that each commit have at least oneJIRA
tag. Please double-check the tag formatting and/or add aJIRA: <issue_URL>
tag for each JIRA Issue.
Guidelines for these entries can be found in CommitRules: https://red.ht/kwf_commit_rules.
To request re-evalution either remove the JIRA label from the MR or add a comment with only the text: request-jirahook-evaluation.
Updated 2024-12-18 17:01 UTC by jirahook - KWF FAQ - Slack #team-kernel-workflow - Source - Documentation - Report an issue
Edited by CKI KWF Bot- No
added Subsystem:kernelinit label
added FixesOK label
added SignoffNeedsReview label
added ConfigsOK label
Fixes Status: FixesOK
No missing upstream fixes for MR 89 found at this time.
Updated 2024-12-18 17:01 UTC by fixes - KWF FAQ - Slack #team-kernel-workflow - Source - Documentation - Report an issue
Edited by CKI KWF BotDCO Signoff Check Report SignoffNeedsReview
The DCO Signoff Check for all commits and the MR description has FAILED.
Some issues were found when validating the DCO Signoff of this MR's description and its commits.
A valid DCO Signoff is given in the format:Signed-off-by: Name <email>
. The Signoff Name and email must match the author name and email of the commit.Validation failures often occur due to syntax so please ensure the Signoff:
- is on a line by itself with no leading whitespace
- does not contain markdown syntax
- has <> brackets around the email address (Gitlab does not render these)
If a Signoff string was copy/pasted from the Gitlab UI it may contain extraneous characters or be missing brackets.
Commit Check Result Expected Signoff Found Signoffs MR Description Missing1 Costa Shulyupin <costa.shul@redhat.com>
None - No valid DCO Signoff was found.
This project requires developers add a Merge Request description and per-commit acknowlegement of the Developer Certificate of Origin, also known as the DCO. This can be accomplished by adding an explicit 'Signed-off-by:' tag to your MR description and each commit.
This Merge Request's commits will not be considered for inclusion into this project until these problems are resolved. After making the required changes please resubmit your merge request for review.
Updated 2024-12-18 17:01 UTC by signoff - KWF FAQ - Slack #team-kernel-workflow - Source - Documentation - Report an issue
Edited by CKI KWF Botadded JIRAMissing label
Kernel Configuration Evaluation: ConfigsOK
This report indicates how any detected Kconfig changes compare with expected changes in the merged .config and with the ARK configs.
This Merge Request has no detected kernel config changes in it.
To request re-evalution after resolving any issues with the configs in the merge request, add a comment to this MR with only the text: request-configs-evaluation
Updated 2024-12-18 06:49 UTC by configshook - KWF FAQ - Slack #team-kernel-workflow - Source - Documentation - Report an issue
Edited by CKI KWF Botadded CommitRefsMissing DependenciesOK labels
changed milestone to %RHEL-10.0
Upstream Commit ID Readiness: CommitRefsMissing
This report indicates how backported commits compare to the upstream source commit. Matching (or not matching) is not a guarantee of correctness. KABI, missing or un-backportable dependencies, or existing RHEL differences against upstream may lead to a difference in commits. As always, care should be taken in the review to ensure code correctness.
P num Sub CID UCIDs Match Notes 1 199a3bca No UCID - Total number of commits analyzed: 1
This Merge Request contains commits that are missing upstream commit ID references. Please review the table.To request re-evalution after resolving any issues with the commits in the merge request, add a comment to this MR with only the text: request-commit-id-evaluation
Updated 2024-12-18 06:49 UTC by commit_compare - KWF FAQ - Slack #team-kernel-workflow - Source - Documentation - Report an issue
Edited by CKI KWF BotACK/NACK Summary: draft report
Expected Approvals (rules that will be created once the MR is out of draft):
- Approval Rule "kernelinit" requests optional ACK(s) from set (arozansk, clrkwllms, hertonrk-rh, jstancek, llong1, prarit, raquini, rrobaina).
Requires 2 more Approval(s).
Updated 2024-12-18 17:01 UTC by ack_nack - KWF FAQ - Slack #team-kernel-workflow - Source - Documentation - Report an issue
Edited by CKI KWF BotCKI Pipelines Status: CKIOK
Summary
All required pipelines have passed!
Pipeline State 64K Debug OK 64K OK CentOS OK Debug OK RHEL Compat OK Realtime Debug OK Realtime OK
Updated 2024-12-18 14:44 UTC by ckihook - CKI FAQ - Slack #team-kernel-cki - Source - Documentation - Report an issue
Edited by CKI KWF Botadded MergeOK label
added CKIRunning label and removed CKIMissing label
Mergeability Summary: MergeOK
This MR can be merged cleanly to its target branch.
Updated 2024-12-18 17:01 UTC by mergehook - KWF FAQ - Slack #team-kernel-workflow - Source - Documentation - Report an issue
Edited by CKI KWF Bot