Skip to content

MQ2Melee fix low level AA tests for 2H Bash, dont try to bash with 2H without AA

The AA name changes of 2019 are implemented, and characters with the respective AAs purchased can bashed. However a bug report was made that showed low levels without the AA, and 2H equipped were trying to bash, and getting spammed with game text, to equip a shield to bash. Workaround, disable / enable bash in melee ini per character, per situation.

The root cause of this issue is with the use of Utilities "GetAAIndexByName" for perhaps not the intended purpose it was written. It returns the index of the AA available to the class, not if it has been purchased.

Alternative approaches considered, I've implemented this purchased AA lookup as two small functions. A generic lookup for a given name, "isAAPurchased" and a help wrapper for it "is2HBashAAPurchased".

The code looks to validating the player class and level to help mitigate uneccessary AA searches and so return the correct results more timely.

A write up of this work is on the RG forums, here. (includes tests, some explain detals and code)

Merge request reports