Skip to content

Migrate utilities from quantify-core

Viacheslav Ostroukhrequested to merge
migrate_utilities into main

Explanation of changes

Before we were using many utilities defined in quantify-core. They are migrated to quantify-scheduler.helpers

Motivation of changes

Utilities in quantify-core are were in fact not used there, and therefore are out of its scope. Probably they were left here during of the split between core and scheduler, when in fact they should have been moved to scheduler alongside with the functions that utilize them.

The only exception is load_json_schema, which is in fact USED in core, however, I think that it should not be a part of public API of quantify-core and it is better to copypaste it (it's a tiny function) than to import it privately. Also, who knows, it may also disappear from core before release of 1.0.

Merge checklist

See also merge request guidelines

  • Merge request has been reviewed and approved by a project maintainer.
  • Merge request contains a clear description of the proposed changes and the issue it addresses.
  • Merge request made onto appropriate branch (main for most MRs).
  • New code is fully tested.
  • New code is documented and docstrings use numpydoc format.
  • CHANGELOG.rst and AUTHORS.rst have been updated (when applicable).
  • CI pipelines pass
    • pre-commit run --all-files --hook-stage commit passes (gitlab-ci),
    • test suite passes (gitlab-ci),
    • no degradation in code-coverage (codacy),
    • no (serious) new pylint code quality issues introduced (codacy),
    • documentation builds successfully (CI and readthedocs),
    • windows tests pass (manually triggered by maintainers before merging).

For reference, the issues workflow is described in the contribution guidelines.

Edited by Viacheslav Ostroukh

Merge request reports