Skip to content

feat: adjust DISTRIBUTION bin mode

Gábor Oszkár Dénesrequested to merge
feat/QTFY-931-adjust-distribution-bin-mode into main

Explanation of changes

Adjust the DISTRIBUTION bin mode.

  • The "repetitions" dimension is removed: it was incorrect before, because even if there were 100 repetitions, it was always 0. Repetitions by definition as a dimension does not even make sense for DISTRIBUTION.
  • The "counts" as dimension has been replaced by f"acq_index_{acq_channel}" to make things more consistent.
  • The "counts" is now an acquisition coordinate, and renamed to f"counts_{acq_channel}" to make it possible to use multiple DISTRIBUTION modes within one schedule.

Merge checklist

See also merge request guidelines

  • Merge request has been reviewed (in-depth by a knowledgeable contributor), and is approved by a project maintainer.
  • New code is covered by unit tests (or N/A).
  • New code is documented and docstrings use numpydoc format (or N/A).
  • New functionality: considered making private instead of extending public API (or N/A).
  • Public API changed: added @deprecated and entry in deprecated code suggestions (or N/A).
  • Newly added/adjusted documentation and docstrings render properly (or N/A).
  • Pipeline fix or dependency update: post in #software-for-developers channel to merge main back in or update local packages (or N/A).
  • Tested on hardware (or N/A).
  • CHANGELOG.md for breaking changes and AUTHORS.md have been updated (or N/A).
  • Update Hardware backends documentation if backend interface change or N/A
  • Check whether performance is significantly affected by looking at the Performance metrics results.
  • Windows tests in CI pipeline pass (manually triggered by maintainers before merging).
    • Maintainers do not hit Auto-merge, we need to actively check as manual tests do not block pipeline

For reference, the issues workflow is described in the contribution guidelines.

Merge request reports