Skip to content

feat: change validator for spin qubits

Explanation of changes

class DispersiveMeasurementSpin(DispersiveMeasurement):
    """
    Submodule containing parameters to perform a measurement.

    The measurement that is performed is using
    :func:`~quantify_scheduler.operations.measurement_factories.dispersive_measurement_spin`.
    """

    def __init__(
        self, parent: InstrumentBase, name: str, *, gate_pulse_amp: float = 0, **kwargs
    ) -> None:
        super().__init__(parent=parent, name=name, **kwargs)

        self.integration_time.remove_validator()
        self.integration_time.add_validator(vals=validators.Numbers(min_value=0, max_value=10e-3))

adding two lines above

Motivation of changes

It is because some sensors want to push the integration time above 100e-6 which is arbitrarily set for transmons (physics). Then, the integration time stays in the allowed range for Qblox, that allows up to 16ms.


Merge checklist

See also merge request guidelines

  • Merge request has been reviewed (in-depth by a knowledgeable contributor), and is approved by a project maintainer.
  • New code is covered by unit tests (or N/A).
  • New code is documented and docstrings use numpydoc format (or N/A).
  • New functionality: considered making private instead of extending public API (or N/A).
  • Public API changed: added @deprecated and entry in deprecated code suggestions (or N/A).
  • Newly added/adjusted documentation and docstrings render properly (or N/A).
  • Pipeline fix or dependency update: post in #software-for-developers channel to merge main back in or update local packages (or N/A).
  • Tested on hardware (or N/A).
  • CHANGELOG.md for breaking changes and AUTHORS.md have been updated (or N/A).
  • Update Hardware backends documentation if backend interface change or N/A
  • Check whether performance is significantly affected by looking at the Performance metrics results.
  • Windows tests in CI pipeline pass (manually triggered by maintainers before merging).
    • Maintainers do not hit Auto-merge, we need to actively check as manual tests do not block pipeline

For reference, the issues workflow is described in the contribution guidelines.

Edited by Gábor Oszkár Dénes

Merge request reports

Loading