Skip to content

Update QTM parameter patches with calls to actual parameters via `wraps` (SE-499)

Thomas Middelburgrequested to merge
wrap-qtm-dummy-params into main

Explanation of changes

The dummy transport in qblox-instruments has been updated a while ago for the QTM, so it's okay to call the actual parameters/methods in integration/end-to-end tests. The parameters/methods are still patched (so that you can test with assert_called etc.) but the wraps argument is used so that the actual parameter/method is called as well, providing some extra validation that the correct method is called.

Merge checklist

See also merge request guidelines

  • Merge request has been reviewed (in-depth by a knowledgeable contributor), and is approved by a project maintainer.
  • New code is covered by unit tests (or N/A).
  • New code is documented and docstrings use numpydoc format (or N/A).
  • New functionality: considered making private instead of extending public API (or N/A).
  • Public API changed: added @deprecated and entry in deprecated code suggestions (or N/A).
  • Newly added/adjusted documentation and docstrings render properly (or N/A).
  • Pipeline fix or dependency update: post in #software-for-developers channel to merge main back in or update local packages (or N/A).
  • Tested on hardware (or N/A).
  • CHANGELOG.md for breaking changes and AUTHORS.md have been updated (or N/A).
  • Update Hardware backends documentation if backend interface change or N/A
  • Check whether performance is significantly affected by looking at the Performance metrics results.
  • Windows tests in CI pipeline pass (manually triggered by maintainers before merging).
    • Maintainers do not hit Auto-merge, we need to actively check as manual tests do not block pipeline

For reference, the issues workflow is described in the contribution guidelines.

Merge request reports