Nv pulse shape change
Explanation of changes
I have made the following changes:
- Renamed the SpectroscopyOperationHermiteMW to SpectroscopyOperationNV.
- changed the nv_pulse_spec_mw in the pulsefactory to perform the sqaure pulse by default but could also perform hermite and gauss.
- changed the Rxyhermite to RxyNV
- changed the rxy_hermite_pulse to rxy_pulse that can perform hermite or gauss
Motivation of changes
As far as I have done the literature survey for the NV centers, majority of them use square pulse shape instead of hermite. But I do not want to take away that option, that is why I provided a choice in nv_pulse_spec_mw.
Merge checklist
See also merge request guidelines
-
Merge request has been reviewed (in-depth by a knowledgeable contributor), and is approved by a project maintainer. -
New code is covered by unit tests (or N/A). -
New code is documented and docstrings use numpydoc format (or N/A). -
New functionality: considered making private instead of extending public API (or N/A). -
Public API changed: added @deprecated
and entry in deprecated code suggestions (or N/A). -
Newly added/adjusted documentation and docstrings render properly (or N/A). -
Pipeline fix or dependency update: post in #software-for-developers
channel to mergemain
back in or update local packages (or N/A). -
Tested on hardware (or N/A). -
CHANGELOG.md
for breaking changes andAUTHORS.md
have been updated (or N/A). -
Update Hardware backends documentation if backend interface change or N/A -
Check whether performance is significantly affected by looking at the Performance metrics results. -
Windows tests in CI pipeline pass (manually triggered by maintainers before merging). - Maintainers do not hit Auto-merge, we need to actively check as manual tests do not block pipeline
For reference, the issues workflow is described in the contribution guidelines.
Summary by CodeRabbit
-
New Features
- Enhanced flexibility in spectroscopy operations with the ability to specify pulse shapes ('Square' or 'Hermite').
- Introduced a new method for selecting pulse shapes based on user input.
-
Improvements
- Updated class and method names to better reflect their functionality and purpose.
Edited by Vatshal Srivastav