Skip to content

Refactoring: create get_used_port_clocks attribute instead of _extract_port_clocks_used

Explanation of changes

_extract_port_clocks_used(Operation|Schedule) has been moved to Operation.get_used_port_clocks() and ScheduleBase.get_used_port_clocks().
In the future it still needs to be moved to subclasses when wet get rid of is_pulse and is_acquisition.

Motivation of changes

It was a private method used publicly.
It was in a util/helpers class when it could live much more nicely in a the Operation/Schedule classes. Hopefully reduces the amount of circular imports by having less imports in a util/helpers class.


Merge checklist

See also merge request guidelines

  • Merge request has been reviewed (in-depth by a knowledgeable contributor), and is approved by a project maintainer.
  • New code is covered by unit tests (or N/A).
  • New code is documented and docstrings use numpydoc format (or N/A).
  • New functionality: considered making private instead of extending public API (or N/A).
  • Public API changed: added @deprecated and entry in deprecated code suggestions (or N/A).
  • Newly added/adjusted documentation and docstrings render properly (or N/A).
  • Pipeline fix or dependency update: post in #software-for-developers channel to merge main back in or update local packages (or N/A).
  • Tested on hardware (or N/A).
  • CHANGELOG.md for breaking changes and AUTHORS.md have been updated (or N/A).
  • Update Hardware backends documentation if backend interface change or N/A
  • Check whether performance is significantly affected by looking at the Performance metrics results.
  • Windows tests in CI pipeline pass (manually triggered by maintainers before merging).
    • Maintainers do not hit Auto-merge, we need to actively check as manual tests do not block pipeline

For reference, the issues workflow is described in the contribution guidelines.

Edited by Gábor Oszkár Dénes

Merge request reports

Loading