Skip to content

Fix Windows test and new Ruff rules

Leon Wubbenrequested to merge
explicit-is-dir-check into main

Explanation of changes

In the hardware_config write_to/read_from it was the case we let file.open() check whether the file was a file and not directory, and raise an exception if it weren't. This wasn't done in Windows, so this check has been added explicitly.

Ruff also added the new PLC0206 rule. This is now fixed in this MR

Motivation of changes

Windows tests were failing https://gitlab.com/quantify-os/quantify-scheduler/-/jobs/8426601582

Merge checklist

See also merge request guidelines

  • Merge request has been reviewed (in-depth by a knowledgeable contributor), and is approved by a project maintainer.
  • New code is covered by unit tests (or N/A).
  • New code is documented and docstrings use numpydoc format (or N/A).
  • New functionality: considered making private instead of extending public API (or N/A).
  • Public API changed: added @deprecated and entry in deprecated code suggestions (or N/A).
  • Newly added/adjusted documentation and docstrings render properly (or N/A).
  • Pipeline fix or dependency update: post in #software-for-developers channel to merge main back in or update local packages (or N/A).
  • Tested on hardware (or N/A).
  • CHANGELOG.md for breaking changes and AUTHORS.md have been updated (or N/A).
  • Update Hardware backends documentation if backend interface change or N/A
  • Check whether performance is significantly affected by looking at the Performance metrics results.
  • Windows tests in CI pipeline pass (manually triggered by maintainers before merging).
    • Maintainers do not hit Auto-merge, we need to actively check as manual tests do not block pipeline

For reference, the issues workflow is described in the contribution guidelines.

Edited by Leon Wubben

Merge request reports