Skip to content

Remove BaseAnalysis.run_from() and .run_until() methods

Viacheslav Ostroukh requested to merge remove_ananlysis_run_from_until into main

CAUTION: breaking change!!!

BaseAnalysis.run_from() and BaseAnalysis.run_until() methods are unlikely used by an average user.

According to tests, they are likely used to functionality of the level of "avoid writing to disk" or "adjust Matplotlib figures". I think in most cases this is a wrong approach to solve that problem. I believe that these methods should be removed for the sake of code simplicity and alternative solutions for the problems they may solve should be develop (not saying that analysis API should be redone from scratch).

Merge checklist

See also merge request guidelines

  • Merge request has been reviewed (in-depth by a knowledgeable contributor), and is approved by a project maintainer.
  • New code is covered by unit tests (or N/A).
  • New code is documented and docstrings use numpydoc format (or N/A).
  • New functionality: considered making private instead of extending public API (or N/A).
  • Public API changed: added @deprecated (or N/A).
  • Tested on hardware (or N/A).
  • CHANGELOG.md and AUTHORS.md have been updated (or N/A).
  • Windows tests in CI pipeline pass (manually triggered by maintainers before merging).

For reference, the issues workflow is described in the contribution guidelines.

Merge request reports