Skip to content

Hotfix alpha settings_overwrite["mpl_transparent_background"] = False

Victor Negîrneac requested to merge fix/mpl_alpha into develop

Explanation of changes

Actively set the alpha of figure for mpl_transparent_background=False

@AdriaanRol another one ASAP please

Motivation of changes

Passing a settings_overwrite={"mpl_transparent_background": False} to the analysis does not make the background white... This fixes it.

Same applies for base_analysis.setting["mpl_transparent_background"] = False


Merge checklist

See also merge request guidelines

  • Merge request has been reviewed and approved by a project maintainer.
  • Merge request contains a clear description of the proposed changes and the issue it addresses.
  • Merge request made onto appropriate branch (develop for most MRs).
  • New code is fully tested.
  • New code is documented and docstrings use numpydoc format.
  • CHANGELOG.rst and AUTHORS.rst have been updated (when applicable).
  • CI pipelines pass
    • black code-formatting passes (gitlab-ci),
    • test suite passes (gitlab-ci),
    • no degradation in code-coverage (codacy),
    • no (serious) new pylint code quality issues introduced (codacy),
    • documentation builds successfully (CI and readthedocs),
    • windows tests pass (manually triggered by maintainers before merging).

For reference, the issues workflow is described in the contribution guidelines.

Edited by Victor Negîrneac

Merge request reports