Skip to content

Hotfix measurement control (follow up from !226)

Victor Negîrneac requested to merge mc_hotfix into develop

Explanation of changes

5 min review, this was a bug introduced in !226 (merged) by accident Ensures the MC representation works even when the instrument is closed or freshly instantiated.

Also renamed the MC in the test file (that needs to be done repo wise ate some point)

Motivation of changes

I got some nasty issue in the test + docs build.

Merge checklist

See also merge request guidelines

  • Merge request has been reviewed and approved by a project maintainer.
  • Merge request contains a clear description of the proposed changes and the issue it addresses.
  • Merge request made onto appropriate branch (develop for most MRs).
  • New code is fully tested.
  • New code is documented and docstrings use numpydoc format.
  • CHANGELOG.rst and AUTHORS.rst have been updated (when applicable).
  • CI pipelines pass
    • black code-formatting passes (gitlab-ci),
    • test suite passes (gitlab-ci),
    • no degradation in code-coverage (codacy),
    • no (serious) new pylint code quality issues introduced (codacy),
    • documentation builds successfully (CI and readthedocs),
    • windows tests pass (manually triggered by maintainers before merging).

For reference, the issues workflow is described in the contribution guidelines.

Edited by Victor Negîrneac

Merge request reports