Skip to content

Ensure line endings are always committed with unix-like style

Victor Negîrneac requested to merge fix/line_endings into develop

Explanation of changes

This MR ensures all text files in the repo use unix-style line endings (lf, aka \n).

@kel85uk Please note this, I think several of the files affected were generated on your windows.

@dcrielaard @luis.miguens @slavoutich @AdriaanRol FYI as well.

I am not 100% sure this will force git on all developers' machines to not commit bad line endings, but a non-exhaustive search indicates so.

By the way, quantify-scheduler already contained a .gitattribute (incomplete) file (quantify-scheduler!197 (merged)).

Motivation of changes

I realized this problem when I was having a look at !226 (merged), on my local Git GUI it seemed like entire files where re-written, and it was just the line ending (that the MR correctly set to unix style). Please note, it seems that gitlab does not show this in the online diff, which is good and bad at the same time.

Git diffs are polluted, things are not consistent, etc.


Merge checklist

See also merge request guidelines

  • Merge request has been reviewed and approved by a project maintainer.
  • Merge request contains a clear description of the proposed changes and the issue it addresses.
  • Merge request made onto appropriate branch (develop for most MRs).
  • New code is fully tested.
  • New code is documented and docstrings use numpydoc format.
  • Changelog has been updated (when applicable).
  • CI pipelines pass
    • black code-formatting passes (gitlab-ci),
    • test suite passes (gitlab-ci),
    • no degradation in code-coverage (codacy),
    • no (serious) new pylint code quality issues introduced (codacy),
    • documentation builds successfully (CI and readthedocs),
    • windows tests pass (manually triggered by maintainers before merging).

For reference, the issues workflow is described in the contribution guidelines.

Edited by Victor Negîrneac

Merge request reports