• Kashyap Chamarthy's avatar
    docs: Fix botched rST conversion of 'submitting-a-patch.rst' · cd6b1674
    Kashyap Chamarthy authored and Thomas Huth's avatar Thomas Huth committed
    I completely botched up the merged[0] rST conversion of this document by
    accidentally dropping entire hunks (!) of text. :-(  I made it very hard
    for reviewers to spot it, as the omitted text was buried deep in the
    document.  To fix my hatchet job, I reconverted the "SubmitAPatch"
    wiki[1] page from scratch and replaced the existing rST with it, while
    making sure I incorporated previous feedback.
    
    In summary, in this reconverted edition:
    
    - I did a careful (to the extent my eyes allowed) para-by-para
      comparison of the wiki and the rST to make sure I didn't omit
      anything accidentally.
    
    - I made sure to work in the cosmetic feedback[2] that Thomas Huth
      pointed out in the merged (and botched) edition:
    
       - fix the hyperlinks in "Split up long patches"
    
       - replace ".". with "does not end with a dot" (in "Write a meaningful
         commit message" section)
    
       - replace "---" with ``---`` so that it doesn't render as an em-dash
         (there were two other occurrences; I fixed those too)
    
    - Use "QEMU" spelling consistently in prose usage
    
    - Add a consistent "refer to git-config" link where appropriate
    
    Thanks to Thomas Huth and Alex Bennée for noticing it on IRC.  And sorry
    for my sloppiness.
    
    Fixes: 9f73de8d ("docs: rSTify the "SubmitAPatch" wiki")
    
    [0] 9f73de8d
    [1] https://wiki.qemu.org/index.php?title=Contribute/SubmitAPatch&oldid=10387
    [2] https://lists.nongnu.org/archive/html/qemu-devel/2021-11/msg03600.html
    
    
    
    Signed-off-by: Kashyap Chamarthy's avatarKashyap Chamarthy <kchamart@redhat.com>
    Message-Id: <20211119193118.949698-2-kchamart@redhat.com>
    Reviewed-by: Eric Blake's avatarEric Blake <eblake@redhat.com>
    [thuth: Some more cosmetical changes, fixed links from external to internal]
    Signed-off-by: Thomas Huth's avatarThomas Huth <thuth@redhat.com>
    cd6b1674