Skip to content

arm64: Typo in isar_feature_aa64_tidcp1

In branch v8.2.0 there seems to be a typo in isar_feature_aa64_tidcp1 (https://gitlab.com/qemu-project/qemu/-/blob/master/target/arm/cpu-features.h?ref_type=heads#L772):

static inline bool isar_feature_aa64_tidcp1(const ARMISARegisters *id)
{
    return FIELD_EX64(id->id_aa64mmfr2, ID_AA64MMFR1, TIDCP1) != 0;
}

This should be id_aa64mmfr1 and not id_aa64mmfr2, to match the TIDCP1 register definition in https://gitlab.com/qemu-project/qemu/-/blob/master/target/arm/tcg/cpu64.c#L1199.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information