Skip to content
  • Cédric Le Goater's avatar
    aspeed/smc: Only wire flash devices at reset · a7538ca0
    Cédric Le Goater authored
    The Aspeed machines have many Static Memory Controllers (SMC), up to
    8, which can only drive flash memory devices. Commit 27a2c66c
    ("aspeed/smc: Wire CS lines at reset") tried to ease the definitions
    of these devices by allowing flash devices from the command line to be
    attached to a SSI bus. For that, the wiring of the CS lines of the
    Aspeed SMC controller was moved at reset. Two assumptions are made
    though, first that the device has a SSI_GPIO_CS GPIO line, which is
    not always the case, and second that it is a flash device.
    
    Correct this problem by ensuring that the devices attached to the bus
    are of the correct flash type. This fixes a QEMU abort when devices
    without a CS line, such as the max111x, are passed on the command
    line.
    
    While at it, export TYPE_M25P80 used in the Xilinx Versal Virtual
    machine.
    
    Resolves: #2228
    Fixes: 27a2c66c ("aspeed/smc: Wire CS lines at reset")
    Reported-by: Thomas Huth <thuth...
    a7538ca0