Skip to content

Updated channel map UI

Jordy Gloudemans requested to merge channel_map_ui_patch into development

Description

Fixing issue #159 as described in that issue. This will allow more flexibility in handling the instrument UI at no extra cost. E.g. both Cluster.disconnect_inputs(5) and Cluster.module5.disconnect_inputs() is now possible.

Additionally, it would be nice if the disconnect and connect methods would also except a None values for the slot and sequencer indices, so that the instrument level methods can target whole modules or even Clusters (same as arm/start/stop_sequencer methods), but this requires some changes in the firmware as well, so it is out of scope for this MR.

Note that I renamed the Sequencer.connect method to Sequencer.connect_sequencer. This is because it can now also be called like Cluster.connect_sequencer and without the connect prefix it would not be clear what it does from the perspective of that level. And this is also consistent with arm/start/stop_sequencer methods for that reason. Let me know what you think, but we can always change it back.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Issue(s)

N/A

Related MRs

!116 (merged)

Testing

Only tested in pipeline. Not tested with hardware yet. Somebody else will need to pick that up.

Notes

Merge checklist

  • Cleaned up code (correct alligment/spacing/code-style, no dead code, etc).
  • Merge request targets development branch.
  • Assigned assignee (you) and reviewers (team-members).
  • Merge request has been reviewed by at least one team-members.
  • All pipelines pass, including manually triggered ones.
Edited by Jordy Gloudemans

Merge request reports