Clus 710 restructure status register
Description
The user should be given less information about the specifics of warnings/errors. The user does not care whether a temperature which is out of range comes from the AFE or the CARRIER, only a developer does. The idea is to keep things specific at the firmware level, but more generic at the qblox-instruments
level. This MR also adds the Voltage out of Range Warning to the SystemStatusFlags
enum, which was only present on the pulsar_src side until now (resulting in the warning breaking the interface).
Summary of changes:
- Grouped temp out of range errors
- Grouped PLL unlocked
- Added hardware fault error (for example, voltage out-of-range would be comprised here)
The new list of flags is as follows:
PLL_UNLOCKED = "PLL is unlocked."
TEMPERATURE_OUT_OF_RANGE = "Temperature is out-of-range."
MODULE_NOT_CONNECTED = "Module is not connected."
MODULE_FIRMWARE_INCOMPATIBLE = "Module firmware is incompatible with the rest of the system."
MODULE_FF_CALIB_FAILED = "The feedback network calibration failed."
HARDWARE_COMPONENT_FAILED = "Hardware component failed"
Type
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to change)
Issue(s)
Related MRs
https://gitlab.com/qblox/packages/software/pulsar_src/-/merge_requests/189
Testing
- Pytest (done)
- Sign-off scripts (done)
Merge checklist
-
Cleaned up code (correct alligment/spacing/code-style, no dead code, etc). -
Merge request targets development
branch. -
Assigned assignee (you) and reviewers (team-members). -
Merge request has been reviewed by at least one team-members. -
All pipelines pass, including manually triggered ones.
Edited by Edmundo Ferreira