Skip to content

Fixed and improved search bar

Ghost User requested to merge github/fork/neikeq/pr-search-bar-fix into master

Important changes:

  • Search no longer selects the results.
  • Return focus to the text editor when hiding the bar.
  • Fix connecting to invalid signal _text_changed. Fixing this made me notice another bug where the caret cursor was being moved to the search result after searching due to text editor writing.
  • Update/redraw the text editor after searching.

After this PR, replace won't longer replace the current selected word (inherited behaviour from FindReplaceDialog) but the current search result. This is because just comparing the selection and the search text ignores the search flags like Match Case and Words Only.

Merge request reports