Skip to content

Refactor (and fix) how the connect button is disabled.

Rafał Mikrut requested to merge github/fork/asynts/asynts.disable-connect-button into master

Created by: asynts

Currently it is possible to switch to the advanced mode (where more nodes are selectable) select a node and then switch back, such that the selected node is no longer selected in the default mode. The connect button, however, is not updated and still enabled.

Here is a video that demonstrates the issue.

I changed it such that the connect button is enabled or disabled when the mode is switched. Additionally, I moved this code into the helper function _update_ok_enabled.

As a side node: was it the right decision to create three individual pull requests (that is #35123, #35148 and this one) or would it have been better to create one pull request for all three issues? I mean all three pull request changed the same file, and all...

Merge request reports