Skip to content

Makes adding port in Visual Script nodes deferred

Rafał Mikrut requested to merge github/fork/timothyqiu/deferred into master

Created by: timothyqiu

This fixes #34458 (closed)

Adding/removing a port will cause the graph to be updated, recreating all the nodes.

So before this fix, the add port button will be destroyed during the handling of its own action event. Although signal emission is safe from destroyed objects, the button's remaining action event handling code still needs to access the button itself, resulting in the crash.

The remove port button's signal was already connected with the CONNECT_DEFERRED flag, so clicking that won't crash.

Merge request reports

Loading