Skip to content

Remove translation change notification when setting the locale of a Translation resource

Michael Alexsander requested to merge github/fork/YeldhamDev/translation_resource_notification_removal into master

I've spend a hour trying to find the source of a bug in my code as to why NOTIFICATION_TRANSLATION_CHANGED was being triggered when I was not changing the game's locale. The cause? Apparently loading a Translation resource via code triggers the set_locale() method in it, triggering the notification.

While I get it why it triggers it when changing the locale of the whole game (via TranslationServer), triggering the notification by changing the locale of a resource doesn't make much sense to me.

Merge request reports