Skip to content

Fix AudioStreamPlayer emitting finished signal on stopping

Andrii Doroshenko requested to merge github/fork/Xrayez/fix-audio-stop-as-finished into master

Closes #33579. (CC @rezgi)

Stopping and finishing a track are treated separately, ensure to reset setstop flag to false on playing again (might also help #17309 because of that).

I think this will break for people who expect/rely on $audio.stop() to emit finished signal as well. The signal is only emitted when the track reaches the end now.

Test project

audio-stream-player-stop-finished.zip (Intro.ogg taken from demo projects).

Merge request reports