Skip to content

Call CRASH_COND_MSG if key not found in HashMap get(key) functions.

Rafał Mikrut requested to merge github/fork/madmiraal/nullpointerdereference into master

Created by: madmiraal

HashMap is currently calling ERR_FAIL_COND_V(!res, *res) when calling get(TKey) and TKey isn't found in the HashMap table. This would result in a dereferenced null pointer being returned to the caller, which is what (I assume) the ERR_FAIL_COND was trying to prevent. If the key is not found in the HashMap then there is no safe TData to return. A CRASH_COND_MSG at least enables a message to be generated before crashing.

Merge request reports