Skip to content

Fix 3D Listener nodes not being used

Rafał Mikrut requested to merge github/fork/mcccclean/dont-ignore-listener-nodes into master

Created by: mcccclean

This PR fixes #17751 (closed).

The issue was that the AudioStreamPlayer3D was simply not looking up listeners at all, it was just getting the current Camera nodes and using them as the basis for the audio calculations. This PR still has the logic iterating over the same Camera list, but checks each camera's Viewport for a Listener node first, and uses that if one is present.

Note that in the issue description @reduz mentioned adding a gizmo, but... I am new to this codebase and I don't really know what that entails, so this PR doesn't cover that, just the actual audio functionality.

Thanks! Let me know if there's anything that should be adjusted or cleaned up!

Merge request reports