Skip to content

Make clippy happy

Asbjørn Olling requested to merge make-clippy-happy into main

Running a linter on the project gives a bunch of easily applied suggestions. I just did the thing and applied the changes.

The only controversial change is probably renaming enum variants to never be all-caps. This is something the rust naming guidelines prescribes.

TBH my gut feeling is that it's a bit uglier. Instruction::DISPON is now called Instruction::Dispon. If they're supposed to be CamelCase, it should probably be Instruction::DispOn instead, right? It's not really clear to me how most of the words should be split up.

I'd also be ok with just allowing things that don't conform to rust naming conventions. Maybe we don't need to 100% the clippy game.

Anyway I split this MR into two commits: one for the naming stuff, and one for everything else. That should make it pretty easy to revert.

Edited by Asbjørn Olling

Merge request reports