Add an optional mode-line indicator

mentioned in issue #9 (closed)

mentioned in commit 5ff2b816

Done! I used -P-. If that is cryptic, we can use Pulsar or whatever.

I used -P-. If that is cryptic, we can use Pulsar or whatever.

I think we should default to readable and obvious. As a litmus test, I ask "Would it make Emacs better or worse if the mode line listed -A- [D] |A| /OG/ ~P~ .T =A= by default? Personally, I think not. Of course, the user can change it to something more cryptic, like * or P or even -P-, if they wish so.

I think we also need a defvar for pulsar-lighter and then :lighter pulsar-lighter in the define-minor-mode. Now, we could also leave the lighter empty by default, if that makes for the best default. What do you think about that?

mentioned in commit 6258c511

I made it a defvar, as it is better for everyone.

I think we should default to readable and obvious.

I think descriptive lighters do not scale. The mode line does not have enough space for all of them. Once you enable 2-3 minor modes, the space is already covered. There is no good solution here, unless it involves tooltips on mouse hover.

I think minor modes should not use lighters except if the lighter contains information beyond the name of the mode. However this doesn't affect me since I use minions. There I only show lighters which contain additional useful information.

Happy minions user checking in!

There I only show lighters which contain additional useful information.

I do the same. Otherwise the mode line is too busy and no longer helpful.

But why use lighters in the first place then? To me this looks like unnecessary branding or intrusive advertisement. As mentioned, there exist reasons for visible lighters:

• If the lighter shows additional useful information, e.g., like flymake.
• If the mode mouse menu provides useful operations.
• If the mode is turned on only temporarily, e.g., overwrite-mode.

But besides that I don't see a reason that minor modes come with a lighter. Is using a lighter supposed to be good practice? I think not every feature available to us must be used. Sometimes this can just lead to clutter as in this case.

...

On 3/25/22 13:30, Protesilaos Stavrou (@protesilaos) wrote:

Happy minions user checking in!

There I only show lighters which contain additional useful information.

I do the same. Otherwise the mode line is too busy and no longer helpful.

I think we all agree. We can have no lighter by default but we can also have an option to have a descriptive lighter for those who need it. How about that?

I don't see the point. If there is no need for a lighter, there is no need for an option. I don't see a point in preemptively and prematurely adding pointless configuration options. My approach would be to remove the lighters from all modes which do not satisfy the criteria I mentioned before. From my experience, these are most modes.

...

On 3/25/22 14:30, Rudolf Adamkovič (@salutis) wrote:

I think we all agree. We can have no lighter by default but we can also have an option to have a descriptive lighter for those who need it. How about that?

See my comment below. I actually used the lighter while configuring the mode, enabling it just in certain modes/situations, etc.

Testing doesn't seem like a sufficient justification for a lighter since it impacts other users negatively. Having it as an option is not as bad but if you set this variable for testing then you can just as well add your own custom testing lighter to mode-line-format or just check the value of the variable pulsar-mode for example with Marginalia. I think it makes a lot of sense to reduce clutter, on the visual side and also on the side of the code.

I think we all agree. We can have no lighter by default but we can also have an option to have a descriptive lighter for those who need it. How about that?

Oh, I thought you needed the lighter. Otherwise I prefer not to pre-emptively add options for such details and will revert this change. Is that okay?

For this mode in particular, I think we already have an excellent "lighter" in place: the pulse effect.

Oh, I thought you needed the lighter. Otherwise I prefer not to pre-emptively add options for such details and will revert this change. Is that okay?

Ha, you wrote the same as I did. I obviously agree.

For this mode in particular, I think we already have an excellent "lighter" in place: the pulse effect.

Exactly. For modes which are visual itself, there is even less the need for a lighter. There is a good example hl-line-mode also does not come with a lighter. So I think it is best practice not use lighters except one of the criteria I mentioned before apply. For all other modes it is just pointless branding, for example what is the point of constantly reminding the user that they turned on Mct, Vertico, Ivy or Helm?

...

On 3/25/22 14:36, Protesilaos Stavrou (@protesilaos) wrote:

Ha, you wrote the same as I did. I obviously agree.

Haha!

What is the point of constantly reminding the user that they turned on Mct, Vertico, Ivy or Helm?

None whatsoever. Which is why minions, delight, etc., are a soft requirement for a decent setup.

Oh, I thought you needed the lighter. Otherwise I prefer not to pre-emptively add options for such details and will revert this change. Is that okay?

I used it a lot for testing, with the mode enabled in a dozen of buffers and disabled in another dozen. Now that my configuration stabilized, I plan to disable it. In this context, I thought: why not leave it in as an option; but you folks do present good points. Go ahead!

I used it a lot for testing, with the mode enabled in a dozen of buffers and disabled in another dozen. Now that my configuration stabilized, I plan to disable it. In this context, I thought: why not leave it in as an option; but you folks do present good points. Go ahead!

All clear!

mentioned in commit 3745de51

closed