This is not a real bug, but looks like some incompatible changes in org-mode starting from version 9.4.
Before the box around org-priority item wasn't extended with one additional space:
And after updating to version 9.4 this box doesn't look as good as it was before:
I'm not sure what should be the solution, maybe to report bug to org-mode or disable this box on theme level.
Edited
Designs
An error occurred while loading designs. Please try again.
Child items
0
Show closed items
GraphQL error: The resource that you are attempting to access does not exist or you don't have permission to perform this action
No child items are currently open.
Linked items
0
Link issues together to show that they're related or that one is blocking others.
Learn more.
Activity
Sort or filter
Newest first
Oldest first
Show all activity
Show comments only
Show history only
Roman Rudakovchanged title from {-org-priority-} face has additional space starting from org-mode 9.4 to org-priority face has additional space starting from org-mode 9.4
changed title from {-org-priority-} face has additional space starting from org-mode 9.4 to org-priority face has additional space starting from org-mode 9.4
I'm not sure what should be the solution, maybe to report bug to org-mode or disable this box on theme level.
In principle, I am fine with adapting to what Org is doing. Though seeing as this used to work with previous versions of Org, I would first investigate whether there is some variable or something that controls this new behaviour.
(defvarorg-priority-regexp".*?\\(\\[#\\([A-Z0-9]+\\)\\] ?\\)""Regular expression matching the priority indicator.A priority indicator can be e.g. [#A] or [#1].This regular expression matches these groups:0 : the whole match, e.g. \"TODO [#A] Hack\"1 : the priority cookie, e.g. \"[#A]\"2 : the value of the priority cookie, e.g. \"A\".")
Oops just saw you posted it! Any way, we need to find out why they have the space at the end. Perhaps they made a mistake or there is some other reason.
So the changes is this, meaning that they were not using (?) that variable before to do font-locking:
;; Old(defunorg-font-lock-add-priority-faces(limit)"Add the special priority faces."(while(re-search-forward"^\\*+ .*?\\(\\[#\\(.\\)\\]\\)"limitt)(add-text-properties(match-beginning1)(match-end1)(list'face(org-get-priority-face(string-to-char(match-string2)))'font-lock-fontifiedt))));; New(defunorg-font-lock-add-priority-faces(limit)"Add the special priority faces."(while(re-search-forwardorg-priority-regexplimitt)(add-text-properties(match-beginning1)(match-end1)(list'face(org-get-priority-face(string-to-char(match-string2)))'font-lock-fontifiedt))))
It seems we have not had any feedback from the mailing lists. I would give it some more time: these things can take a while. I think we have found the cause and your workaround gets the job done.
Was about to report it. Very nice to see how much buzz you two have already made about such a minor visual issue that is nonetheless distracting
Thanks @japhir for the feedback! Did you have the chance to try Roman's updated solution? If it works for you too without any side effects, then it may be a good idea to reply to the mailing list thread we have: just to confirm that it works properly (you need to add emacs-orgmode@gnu.org to the recipients).
(nothing happens when I click the "Reply to.." button in the browser. Perhaps I should try in Chromium.
No worries! What matters is whether Roman's workaround works for you.
I will reply to that thread later today. If you wish to be in the Cc group, please send me your email. My contact info: https://protesilaos.com/contact
Hello again! The issue appears to be fixed in Org's upstream, as of commit b1de0c8e4 by Kyle Meyer. Of course this will only affect users who are tracking the git source, instead of version 9.4.
I am keeping this issue open and tagging it accordingly. If you think something is wrong, please let me know and I can help communicate with the Org developers.
Hello, Protesiaos! Sorry for late response. I see you removed boxes from org-priority face and I agree it's reasonable solution so far. Thanks for great work!
From my perspective I think this issue can be closed because there are no issues with latest version of modus themes, but of course it's up to you.
Thank you Roman! I think it is good that we helped fix the problem upstream, regardless of how the Modus themes are currently configured. I am closing this issue now.