Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • modus-themes modus-themes
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Protesilaos Stavrou
  • modus-themesmodus-themes
  • Issues
  • #296
Closed
Open
Created Mar 12, 2022 by Daniel Mendler@minad

wid-edit buttons

In #282 (closed) we discussed button styling and improved the default style of the customize buttons (cus-edit) and the eww buttons. It turns out that cus-edit.el uses wid-edit.el and derives its buttons from the wid-edit buttons, e.g., push-button. The faces of the widget buttons are overriden in custom--initialize-widget-variables. Now I wonder if we should simply apply the styling of the box buttons to all the widget buttons for greater coherence and a prettier interface. This way all packages which use widget.el/wid-edit.el directly will get improved looks.

You can check out the widget-example from https://www.gnu.org/software/emacs/manual/html_mono/widget.html#Programming-Example. Compare the looks with and without the following settings:

(setq widget-link-prefix " "
      widget-link-suffix " "
      widget-push-button-prefix " "
      widget-push-button-suffix " ")
(face-spec-reset-face 'widget-button)
(face-spec-reset-face 'widget-button-pressed)
(set-face-attribute 'widget-button nil :inherit 'modus-themes-box-button)
(set-face-attribute 'widget-button-pressed nil :inherit 'modus-themes-box-button-pressed)

Unfortunately, we cannot overwrite the prefixes/suffixes in the theme, but these adjustments could be part of the manual. Here is a screen shoot with and without the adjustments. If we adjust the faces we may want to rename modus-themes-box-button(-pressed) to modus-themes-widget-button(-pressed). This would reduce the confusion regarding button faces and buttons a little bit.

wid-buttons

Edited Mar 12, 2022 by Daniel Mendler
Assignee
Assign to
Time tracking