Definition for image-dired-thumb-mark face

Please consider adding a definition for image-dired-thumb-mark-face. I suggest using the same background as what you use for the foreground of dired-marked.

Thanks!

Thank you @skangas! I am now building from emacs.git to give it a try.

I just noticed that d in image-dired uses the same face as for selections. Maybe this can be changed upstream so that we have different marks for deletions and selections, as in regular dired?

With the current implementation, it might be better to you the "alt" background, which I apply to those "ambiguous" cases. Compare the two:

Yes, we should definitely use two different faces for flagged and marked images. I had actually already added such an item to my TODO list, but given your above comment I went ahead and implemented it today: https://git.savannah.gnu.org/gitweb/?p=emacs.git;a=commit;h=733eff49d33dfd8df5f44def7dff7046f3ee61a4

So on current master we now have the new image-dired-thumb-flagged face! I hope this will make it easier for you to find a nice way to style this, at least in Emacs 29.

mentioned in commit 637a79ae

Thank you for all your work on Emacs! I just pushed the commit. Some screenshots below. Note that I am not actually re-using the same background colours from the Dired marks. The reason is that those also have a :foreground attribute which makes them stand out more---otherwise the backgrounds are fairly faint. Though I think I have kept with the spirit of how Dired marks are styled and so things look consistent.

Default style

Deuteranopia (with non-nil for modus-themes-success-deuteranopia)

closed

All those screenshots look good to me, thanks for fixing this!

By the way, for posterity let me just note that image-dired-thumb-mark is new in Emacs 28 while image-dired-thumb-flagged is new in Emacs 29.

By the way, for posterity let me just note that image-dired-thumb-mark is new in Emacs 28 while image-dired-thumb-flagged is new in Emacs 29.

Good to know!

I will publish a new version of the themes some time in the coming days. Though that will go straight into Emacs 29.