pgrep: optimize command name copying

strncpy() implementations in glibc and musl use memset() to zero the entire destination string past the source string length. This is hot code path that runs per PID. It makes strncpy() take more cycles than anything else.

Use memccpy() instead since it never touches the destination past the string terminator.

Signed-off-by: Baruch Siach baruch.siach@siklu.com

pgrep.c

@@ -643,18 +643,18 @@ static struct el * select_procs (int *num)
 
 		if (opt_long || opt_longlong || (match && opt_pattern)) {
 			if (opt_longlong && task.cmdline)
-				strncpy (cmdoutput, cmdline, cmdlen - 1);
+				memccpy (cmdoutput, cmdline, '\0', cmdlen - 1);
 			else
-				strncpy (cmdoutput, task.cmd, cmdlen - 1);
+				memccpy (cmdoutput, task.cmd, '\0', cmdlen - 1);
 			cmdoutput[cmdlen - 1] = '\0';
 		}
 
 
 		if (match && opt_pattern) {
 			if (opt_full && task.cmdline)
-				strncpy (cmdsearch, cmdline, cmdlen - 1);
+				memccpy (cmdsearch, cmdline, '\0', cmdlen - 1);
 			else
-				strncpy (cmdsearch, task.cmd, cmdlen - 1);
+				memccpy (cmdsearch, task.cmd, '\0', cmdlen - 1);
 			cmdsearch[cmdlen - 1] = '\0';
 
 			if (regexec (preg, cmdsearch, 0, NULL, 0) != 0)