Skip to content

Enforce firestore transactions

Luke Benstead requested to merge enforce-firestore-transactions into 30-integrate-firestore

This MR fixes transactions in Firestore so that they actually work! It involved quite a lot of refactoring of the insert + update commands and a complete rewrite of unique checking. Things left to do:

  1. Unique constraints aren't being deleted! This is okay because we check the validity of clashing unique constaints, but it's slow. I suggest we provide some kind of background task that cleans up steal markers.
  2. There's 2 failing tests. One to do with caching, another to do with constraints.
Edited by Luke Benstead

Merge request reports