Skip to content

args: remove dead code

Oliver Smith requested to merge ollieparanoid/pmbootstrap:remove-dead-code into master

Remove a bunch of commented out code:

  • debug leftovers
  • update_work(): a function that used to replace $WORK in all kinds of arguments to pmbootstrap, with the actual work dir. This seemed like a good idea when I made this initially, but in hindsight it's clear that this made args just much more complex. I'm glad that Caleb removed this. Now $WORK only gets removed in one place, for mount points, which makes much more sense.
  • args.from_argparse and related comment: pmbootstrap used to make a full copy of its args, so in some cases it could go back before $WORK was replaced IIRC. This isn't great, but even worse is that this caused each stack trace to say something like infinite recursion on args. I'm also glad that Caleb got rid of this :)

Merge request reports