Skip to content

Update linux-samsung-p4wifi config to be based on mainline tegra_defconfig

postmarketOS Bot requested to merge Decatf:device-p4wifi into master

Created by: Decatf

Previously the kernel config was based on the config from a mainline-ish kernel for Android. I have dropped the remaining Android specific patches. It turned out most weren't needed. I generated a new config based on tegra_defconfig which is in mainline. The code is now mainline with out-of-tree drivers and corresponding hardware specific patches/fixes/hacks. No more Android stuff.

There's no functionality change. The working / not working status remains the same.

@ollieparanoid: You asked before about a having a common branch such as linux-postmarketos-tegra. There are quite a few device specific quirks which I am guarding with checks in probe/init functions. Example:

if (of_machine_is_compatible("samsung,p4wifi")) {
     // handle device quirks
}

A pretty low impact example here: https://github.com/Decatf/linux/commit/8f7ebdc547eebad405104a31723c8ab65e019353. There are several such things throughout. This method is taken from mainline but they use it very sporadically. I think there's only a handful of uses.

At the moment there is one ugly hack that I use in order to increase the system partition size. The default is really small (450MB). It's kind of ugly and prevents the kernel from being used in a generic way. I did not guard this with the of_machine_is_compatible check. It could be done there too if necessary. Otherwise this would remain as a device specific kernel.

Tegra already has sort of decent mainline support for basic SOC functionality anyways. I don't know what the approach is for linux-postmarketos-qcom but there's nothing critical for general functionality of the Tegra 2 SOC that is out-of-tree. What is out-of-tree are only the device specific quirks and ugly hacks for such things.

So yeah that's the state of this device. It doesn't matter to me if it remains as device specific kernel but it's not out of the realm of possibility for this device to exist as part of a common tegra kernel.

Merge request reports