Skip to content
Snippets Groups Projects

main/postmarketos-mkinitfs: make android_usb attrs customizable

Merged Danct12 requested to merge Danct12/pmaports:configfs-android into master
All threads resolved!

Based on !706 (merged), this commit will makae idVendor and idProduct customizable on some downstream kernels.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Danct12 added 1 commit

    added 1 commit

    • 521373da - main/postmarketos-mkinitfs: make android_usb attrs customizable

    Compare with previous version

  • Danct12 added 1 commit

    added 1 commit

    • d70a91bc - main/postmarketos-mkinitfs: make android_usb attrs customizable

    Compare with previous version

  • Alexey Min resolved all threads

    resolved all threads

  • The branch name Danct12:configfs-android is wrong, configfs and android_usb are different things, but this does not matter of course.

    I'm going to test this now on samsung-klte and report back

  • Well, it works, at least it does not break anything for me

    Tested from this branch: https://gitlab.com/minlexx/pmaports/commits/minlexx/samsung-klte-downstream-test-usb-attrs

    [ 3880.087566] usb 1-1: new high-speed USB device number 8 using xhci_hcd
    [ 3880.236589] usb 1-1: New USB device found, idVendor=04e8, idProduct=6860, bcdDevice= 2.32
    [ 3880.236593] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3

    I think, Android init scripts already do the same (init.usb.sh? or smth) that are run inside lxc container.

    Edited by Alexey Min
  • Oliver Smith added 1 commit

    added 1 commit

    Compare with previous version

  • LGTM. Thanks for the patch @Danct12, and thanks for testing @minlexx!

  • Oliver Smith approved this merge request

    approved this merge request

  • merged

  • Danct12 mentioned in commit dd028490

    mentioned in commit dd028490

  • Please register or sign in to reply
    Loading