Skip to content
Snippets Groups Projects

Draft: google-corsola: add audio support

Closed jenneron requested to merge jenneron/corsola-ucm into master
3 unresolved threads

Add ucm configs and symlink for SOF firmware. Doing it in the firmware subpackage because it doesn't work without linux-firmware-mediatek.

Can be tested with mrtest add 4834

Edited by jenneron

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Oliver Smith
  • jenneron added 1 commit

    added 1 commit

    • 7c3fc5ad - google-corsola: add audio support

    Compare with previous version

  • jenneron added 1 commit

    added 1 commit

    • 1abea20b - google-corsola: add audio support

    Compare with previous version

  • Oliver Smith approved this merge request

    approved this merge request

  • f_ (not used) approved this merge request

    approved this merge request

  • clayton craft
  • clayton craft approved this merge request

    approved this merge request

    • what is the status of this MR?

      Did someone had the chance to test this?

    • Seems like @catto24 was going to try it, but it's unclear if they did

    • Hi, I dug into this topic. @jenneron asked me (on IRC) to comment here.

      First of all, we need linux-firmware-202404*, as MediaTek pushed an update to SOF FW that solves platform hang. Second, I'm still figuring out issues with audio codec. RT5682S shares I2S3 link with IT6505, and even if I removed a pointer to that bridge, it still fails to initialize it.

      I believe that I'm close to getting it working, but unfortunately had another round of health issues this week. While working on it, I also fixed SVS and LVTS (Smart Voltage Scaling, Thermal) which will result in better performance and battery life.

      Will need to talk to Angelo, as I want to completely re-write devicetree for this SoC and boards because currently it's a complete mess.

    • Thanks a lot for the update. Good luck with that, and we'll be very happy to incorporate the changes. In the meanwhile, I'm setting as draft to remove from the review queue

    • I tested this briefly, I couldn't get the mrtest-tool to work, so I just manually rebased this on top of the latest pmaports-master, and built the packages and installed them. With both pipewire and when trying to use ALSA directly, I see that the application tries to start to play something, but the time in the counter never goes forward. It stays stuck at 00:00:00 for example when trying to play something with mpv.

      Edited by Mika Tammi
    • What made you think PipeWire would solve the issue? Problem is in firmware/kernelspace, DeviceTree to be more specific. There are issues with I2S3 link shared with bridge providing USB-C video output.

      If everything goes well, I should look into it again next week. I've been busy recently with 7 different projects.

    • Sorry, I meant it the other way around, I had pipewire in use, then I disabled pipewire to make sure it does not break anything, and then tested with just ALSA directly to see same kind of behavior.

      I'll be happy to test the patch when you have it in testable condition

    • Someone sent me magneton/steelix after seeing my talk at 37C3 so I have hardware to test, but sure thing - more testing welcome :smile_cat:

    • don't forget about me! :> image

    • Please register or sign in to reply
  • Pablo Correa Gomez marked this merge request as draft

    marked this merge request as draft

  • Sorry to bother you @jenneron,

    but we've detected that this merge request hasn't seen any recent activity. If you need help or want to discuss your approach with developers you can ping @postmarketOS. You can also ask on matrix in #devel:postmarketos.org or #postmarketos-devel on OFTC. If no further activity occurs in this MR, postmarketOS developers may close it in the future.

    Thanks for your contribution.

  • Øyvind Kolås mentioned in merge request !5456 (merged)

    mentioned in merge request !5456 (merged)

  • Author Developer

    Closing in favor of !5456 (merged)

  • closed

  • Øyvind Kolås mentioned in commit 64543552

    mentioned in commit 64543552

  • Please register or sign in to reply
    Loading