Draft: Discussion about MINETEST patch for runtime TS detection

Minetest runtime cannot detect touchscreen, so let's compile minetest same way as it's done on Android to get on screen control.

There is a open issue about it here: https://github.com/minetest/minetest/issues/10062

Tested on OnePlus 6T (it's playable, both portrait and landscape mode):

added 1 commit

• 3ce6efaa - minetest: compile with touchscreen support

Compare with previous version

Another option would be using a different package name, such as minetest-touch.

What do you think?

changed the description

changed the description

How much did you have to change the APKBUILD to support this? Would alpine accept this change?

Might be possible to change Alpine APKBUILD to compile it twice? Once with touchscreen support, once without and have them in two subpackages (with a .desktop file each, at least somehow identifying the touchscreen variant)

@z3ntu woke up and this was exactly my thought.

@craftyguy one line, I think I'll propose this change to Alpine with minetest-touch as a conflicting package with minetest and one sed over .*metainfo.xml

edit: but please do not close so far.

kookbook package might be a decent inspiration how to split it aports-wise (it's not compiled twice there but I think you get what I mean)

https://pkgs.alpinelinux.org/packages?name=kookbook*&branch=edge&repo=&arch=aarch64&maintainer=

https://git.alpinelinux.org/aports/tree/community/kookbook/APKBUILD

I'm going to mark this as "draft" then, so that it doesn't show up in lists of MRs that need reviews. Feel free to remove "draft" once you figure out where this package will live and if changes in pmaports are needed to support it!

Tried this today (with mrtest of course ) and it really works pretty nice! Super happy to see a game on pmOS with touchscreen support!

marked this merge request as draft

We need a decision. So far, I'm unable to autodetect touchscreen (haven't spend effort + in 5.9.0 will migrate input to SDL2, so not much sense to put effort into old way)

What I can do with https://github.com/minetest/minetest/pull/14075 is toogle touchscreen from settings (not hardcoded anymore).

1. If I'm going ask Alpine to ship the patch, it will be with disabled touchscreen and default to keyboard (approx these are optimal settings which needs to be adjusted in ~/.minetest/minetest.conf or set in the settings one by one:

   clickable_chat_weblinks = false
   autojump = true

2. we can have the patch only in pmOS, with default -DENABLE_TOUCH=1 which sets these at build-time. But on other side for OPTIMAL KEY/MOUSE gameplay these needs to be altered s/false/true/

Your choice!

• https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/55520

changed title from Draft: minetest: compile with touchscreen support to Draft: Discussion about MINETEST patch for runtime TS detection

changed the description

added 130 commits

• 3ce6efaa...c8edef78 - 129 commits from branch postmarketOS:master
• 5683a174 - minetest: compile with touchscreen support

Compare with previous version

added 1 commit

• 8e901221 - minetest: compile with touchscreen support

Compare with previous version

added 1 commit

• 9f7022e9 - minetest: compile with touchscreen support

Compare with previous version

added 1 commit

• 797b96d4 - minetest: compile with touchscreen support

Compare with previous version

added 1 commit

• 5c5a6977 - minetest: compile with touchscreen support

Compare with previous version

added 1 commit

• bbd5fb26 - minetest: compile with touchscreen support

Compare with previous version

added 1 commit

• a3c81c3a - minetest: compile with touchscreen support

Compare with previous version

Few news, see https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/55520

• LTO (smaller binaries)
• basic autodetection of touchscreen (no need to edit config for basic stuff)

Touchscreen switch got merged, what about keeping the package until there will be 5.9.0? I can throw a top patch with form factor based detection (so pmOS will auto-enable touch in 99.9% cases).

I'm closing this MR as we're getting really close to the 5.10 (or whatever comes after 5.9.0) release and the changes needed for pmOS devices work properly are already in and most of preparation work for the release happened (-ing) in https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/55520

Recently rebased, so feel free to try again if it's still good with your device!

closed

Update: freshly released 5.9.0 in Alpine edge has touchscreen auto-detection enabled. Enjoy!

Awesome, thanks a lot for working on this! It's amazing to have games coming to Linux phones!!