Skip to content

Draft: */device-*: remove scaled from phoc.ini

Pablo Correa Gomez requested to merge phoc.ini into master

Removing the file when empty, and updating all pkgver to use single digit, since there's no clear consistency (see #1717 (closed)), and this is easier to script.

Fixes #2179

The main rationale is, if this isn't working with defaults, then it should be fixed upstream, and not hacked in the config. It's probably relevant that people with devices in community and phosh give this a test. So I'm tagging the testing team:

Since these are too few testers, @TravMurav, @Minecrell this affects some of you devices, do you want to have a look?

Devices affected. If you have one of the affected devices, we would greatly appreciate if you could install wlr-randr $ sudo apk add wlr-randr, and comment with the output for:

$ wlr-randr
$ cat /sys/firmware/devicetree/base/compatible

Community:

  • device-asus-me176c
  • device-fairphone-fp4
  • device-lenovo-a6000
  • device-lenovo-a6010
  • device-samsung-a3
  • device-samsung-gt510, tested
  • device-samsung-gt58, equivalent display to gt510
  • device-samsung-serranove
  • device-xiaomi-scorpio

Testing

  • device-alcatel-idol3
  • device-alcatel-idol347
  • device-asus-grouper
  • device-asus-tf201
  • device-asus-tf300t
  • device-asus-tf300tg
  • device-asus-tf700t
  • device-asus-tilapia
  • device-bq-piccolo default scaling factor is wrong: !4541 (comment 1641672340)
  • device-fairphone-fp2
  • device-huawei-y635
  • device-lg-c50
  • device-lg-hammerhead
  • device-microsoft-surface-rt
  • device-motorola-smi !4541 (comment 1638765173)
  • device-oneplus-cheeseburger
  • device-oneplus-dumpling
  • device-oneplus-oneplus3t
  • device-pegatron-chagall
  • device-pine64-pinenote
  • device-pine64-pinetab
  • device-samsung-a6plte
  • device-samsung-a7
  • device-samsung-codina-tmo
  • device-samsung-cprime
  • device-samsung-fortunaltezt
  • device-samsung-gavini
  • device-samsung-gprimeltexx
  • device-samsung-grandpplte
  • device-samsung-kyle
  • device-samsung-skomer
  • device-sony-pioneer
  • device-xiaomi-gemini
  • device-xiaomi-natrium
  • device-xiaomi-polaris
  • device-xiaomi-sagit
  • device-xiaomi-surya
  • device-xiaomi-vayu
Edited by Pablo Correa Gomez

Merge request reports